Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to embedded-hal=1.0.0-alpha.10 #663

Merged

Conversation

rursprung
Copy link
Contributor

there were various breaking changes in alpha.9 and alpha.10 which have been applied here. see their changelog for further details.

important: this is completely untested beyond "it compiles", please test this carefully!
compilation has been tested with the stm32f401 feature, the CI will show whether it'll also compile for all others.

note that this does only the bare minimum to make it build against the new version - it does not implement any of the newly added APIs. this can be done in subsequent commits.

this fixes #602

@rursprung rursprung force-pushed the update-to-embedded-hal-1.0.0-alpha.10 branch from aa6beef to 008fbeb Compare July 2, 2023 11:36
@burrbull
Copy link
Member

burrbull commented Jul 2, 2023

#653

@rursprung
Copy link
Contributor Author

#653

shit - i missed that! should i abandon this PR? i think this one here would be ready (i just fixed the additional blocking renaming which failed the CI before as i hadn't seen it due to the feature selection when building locally)

@rursprung rursprung force-pushed the update-to-embedded-hal-1.0.0-alpha.10 branch from 008fbeb to 84513c3 Compare July 2, 2023 11:39
@burrbull
Copy link
Member

burrbull commented Jul 2, 2023

Could you move other changes from #653 to this PR? Then I merge it.

rursprung and others added 2 commits July 2, 2023 13:53
there were various breaking changes in alpha.9 and alpha.10 which have
been applied here. see [their changelog][embedded-hal-1.0.0-alpha.10]
for further details.

important: this is completely untested beyond "it compiles", please test
this carefully!
compilation has been tested with the `stm32f401` feature, the CI will
show whether it'll also compile for all others.

note that this does only the bare minimum to make it build against the
new version - it does not implement any of the newly added APIs. this
can be done in subsequent commits.

this fixes stm32-rs#602

[embedded-hal-1.0.0-alpha.10]: https://github.com/rust-embedded/embedded-hal/blob/v1.0.0-alpha.10/embedded-hal/CHANGELOG.md
@rursprung rursprung force-pushed the update-to-embedded-hal-1.0.0-alpha.10 branch from 84513c3 to 6fa9e55 Compare July 2, 2023 11:53
@rursprung
Copy link
Contributor Author

Could you move other changes from #653 to this PR? Then I merge it.

done (with the exception of the Cargo.toml changes, see my comment on your PR)

@burrbull burrbull added this pull request to the merge queue Jul 2, 2023
Merged via the queue into stm32-rs:master with commit 7e46586 Jul 2, 2023
@rursprung rursprung deleted the update-to-embedded-hal-1.0.0-alpha.10 branch July 2, 2023 12:02
@burrbull
Copy link
Member

burrbull commented Jul 4, 2023

alpha.11 released

@rursprung
Copy link
Contributor Author

alpha.11 released

well, that was bad timing 😅
i've now created #668 for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update to embedded-hal:1.0.0-alpha.10
2 participants